View source for Module talk:Check for deprecated parameters

{{oldtfdfull|date= 2019 December 30 |result=no consensus |disc=Module:Check for deprecated parameters}}
{{Talk header}}
{{WikiProject banner shell|
{{WikiProject Templates|module_for_template_maintenance=y}}
}}

== Review request ==

{{ping|hike395|Jonesey95|Frietjes}} as some of the best template editors I know, I'd love to get your feedback on this module. I've been doing a lot of work cleaning up [[:Category:Deprecated parameters|Deprecated parameters]] and one of the ongoing frustrations has been figuring out which parameter is deprecated. So I took the lead from {{u|Frietjes}}' awesome [[Module:Check for unknown parameters]]. What this does is take a list of parameters including their old value and what they should be replaced with. If the module is implemented on a template, when that template is transcluded with deprecated parameters it will put the page in a given category. Additionally, when the page is previewed it will display ''{{red|'''Warning''': Page using <template name> with deprecated parameter "old_param". replace with "new_param" (this message is shown only in preview).}}'' I have a very rudimentary testcase setup at [[User:Zackmann08/deprecated page]] so that you can see what it does. To avoid redlinked categories, I'm passing in <code><nowiki>[[:Category:Pages using user:Zackmann08/deprecated template with deprecated parameters|_VALUE_{{PAGENAME}}]]</nowiki></code> so it will actually render a link. Anyway, no rush at all, but would love any feedback you can provide! --'''[[User:Zackmann08|<span style="color:#00ced1">Zack</span><span style="color:#007F94">mann</span>]]''' (<sup>[[User_talk:Zackmann08|Talk to me]]</sup>/<sub>[[Special:Contributions/Zackmann08|<span style="color:orange;">What I been doing</span>]]</sub>) 20:07, 30 November 2018 (UTC)
:'''Update''': testing with {{tl|Infobox building}} right now... --'''[[User:Zackmann08|<span style="color:#00ced1">Zack</span><span style="color:#007F94">mann</span>]]''' (<sup>[[User_talk:Zackmann08|Talk to me]]</sup>/<sub>[[Special:Contributions/Zackmann08|<span style="color:orange;">What I been doing</span>]]</sub>) 21:22, 1 December 2018 (UTC)

== Preview warning and hatnotes moving to templatestyles ==

Page watchers may be interested in {{slink|MediaWiki talk:Common.css|Preview warning and hatnotes moving to TemplateStyles}} [[User:Izno|Izno]] ([[User talk:Izno|talk]]) 00:22, 29 April 2021 (UTC)

== Syntax ==

What if there is no new_param which is replacing old_param, i.e. the parameter is no longer supported? &mdash;&nbsp;Martin <small>([[User:MSGJ|MSGJ]]&nbsp;·&nbsp;[[User talk:MSGJ|talk]])</small> 17:43, 5 December 2023 (UTC)

== Another review ==

{{ping|hike395|Jonesey95|Frietjes}} so almost 7 years later... Another review request. In the [[Module:Check_for_deprecated_parameters/sandbox|sandbox]] I have mocked up a hopeful improvement which takes a CSV set of param(s) to simply be removed. I.E. there is no replacement param, the param just needs to go. 

Would be called like so:
<pre>
{{#invoke:Check for deprecated parameters/sandbox|check
| category = [[Category:Deprecated params]]
| _remove = removeme, remove2, remove3, remove 4, remove me 5
| old_param1 = new_param1 
}}
</pre>
And would display a preview message saying ''{{red|'''Preview warning''': Page using TEMPLATE_NAME with deprecated parameter "removeme". It should be removed.}}'' 

I ''think'' it is good to go, but would definitely like a second or third set of eyes on it. 

{{compare pages|Module:Check for deprecated parameters|Module:Check for deprecated parameters/sandbox|Here is the comparison}}. I'm not nuts about having a 2nd if statement that is largely duplicate code, but feel like it isn't really worth it to abstract it out into a function. Will if you think I should though. 

{{U|MSGJ}} this one is for you! '''[[User:Zackmann08|<span style="color:#00ced1">Zack</span><span style="color:#007F94">mann</span>]]''' (<sup>[[User_talk:Zackmann08|Talk to me]]</sup>/<sub>[[Special:Contributions/Zackmann08|<span style="color:orange;">What I been doing</span>]]</sub>) 09:26, 14 October 2025 (UTC)
: I would suggest making the delimiter the "=" sign since it is valid to have a comma in a parameter name. [[User:Frietjes|Frietjes]] ([[User talk:Frietjes|talk]]) 00:10, 15 October 2025 (UTC)
::{{ping|Frietjes}} {{facepalm}} You can put a comma in a parameter name?! WHY would you do that... I drew my ispiration for [[Module:template wrapper]] which uses CSVs. In any case, I'm worried about how that will look to the editor since "{{=}}" is traditionally used to assign a value to a parameter. IMHO it is harder to read and more confusing. What do you think about using a semicolon instead? I cannot fathom someone using a semi colon in a param name... - '''[[User:Zackmann08|<span style="color:#00ced1">Zack</span><span style="color:#007F94">mann</span>]]''' (<sup>[[User_talk:Zackmann08|Talk to me]]</sup>/<sub>[[Special:Contributions/Zackmann08|<span style="color:orange;">What I been doing</span>]]</sub>) 03:32, 15 October 2025 (UTC)
:::{{ping|Frietjes}} I've updated it to use {{code|;}} as the delineator per my previous comments. Also cleaned up extraneous comments that I missed last night. Let me know if that looks good. '''[[User:Zackmann08|<span style="color:#00ced1">Zack</span><span style="color:#007F94">mann</span>]]''' (<sup>[[User_talk:Zackmann08|Talk to me]]</sup>/<sub>[[Special:Contributions/Zackmann08|<span style="color:orange;">What I been doing</span>]]</sub>) 05:52, 15 October 2025 (UTC)
:::: it is valid to have a semicolon in a parameter name as well, which is probably why [[Module:TemplatePar]] uses = instead. [[User:Frietjes|Frietjes]] ([[User talk:Frietjes|talk]]) 21:08, 20 October 2025 (UTC)
:::::I respect the hell out of your opinion, but I decided to push forward with the use of semi-colon in favor of readability. [[Module:Check for clobbered parameters]] uses this so I think it should work. I just really don't see a use case where someone has a semi-colon in their param name. Plus the worst case scenario is that that parameter can't be properly listed for deprecation with this template. '''[[User:Zackmann08|<span style="color:#00ced1">Zack</span><span style="color:#007F94">mann</span>]]''' (<sup>[[User_talk:Zackmann08|Talk to me]]</sup>/<sub>[[Special:Contributions/Zackmann08|<span style="color:orange;">What I been doing</span>]]</sub>) 07:29, 22 October 2025 (UTC)

== Unusual quotation mark placement ==

Editing and previewing [[Special:Permalink/1329046066]] displays the following message: {{tq|Preview warning: Page using Template:Infobox criminal with deprecated parameter ""nationality". It should be removed."}} The outer pair of quotation marks seems undesirable. [[User:1234qwer1234qwer4|1234qwer]][[User talk:1234qwer1234qwer4|1234qwer]][[Special:Contribs/1234qwer1234qwer4|4]] 03:46, 26 December 2025 (UTC)

:{{fixed}} [[User:1234qwer1234qwer4]] Was actually an issue with [[Special:Diff/1329449570|implementation]] over at {{tl|Infobox person}}. Good catch. Thank you! '''[[User:Zackmann08|<span style="color:#00d5ff">Zack</span><span style="color:#007F94">mann</span>]]''' (<sup>[[User_talk:Zackmann08|Talk to me]]</sup>/<sub>[[Special:Contributions/Zackmann08|<span style="color:orange">What I been doing</span>]]</sub>) 04:38, 26 December 2025 (UTC)